mediamonks / frontend-coding-standards

Media.Monks - Frontend Coding Standards
60 stars 23 forks source link

Add default tsconfig.json #12

Open skulptur opened 4 years ago

skulptur commented 4 years ago

This uses the default tsconfig.json generated with tsc --init (tsc Version 3.9.5).

Only change from that right now is adding "importsNotUsedAsValues": "error"

psimk commented 2 years ago

I think that we don't need a default tsconfig.json, as it will have to be updated either whenever TS decides to add something or when node upgrades and we need to support a new module or target.

So I would much rather have tsconfig.json's defined in our skeletons, where we can change them when we decided to bump our Node or Typescript versions

ThaNarie commented 2 years ago

So I would much rather have tsconfig.json's defined in our skeletons, where we can change them when we decided to bump our Node or Typescript versions

That's something that should definitely happen.

I think that we don't need a default tsconfig.json, as it will have to be updated either whenever TS decides to add something or when node upgrades and we need to support a new module or target.

I think the main reason for this is "documentation" purposes (and) as a starting point for any other project/library/skeleton that we create.

Maybe instead of a file, we could make it a markdown page, that includes:

And for the bottom 2, an explanation for why we dictate or advise these settings, to serve as documentation.

@psimk @skulptur how do you feel about that?

ThijsTyZ commented 2 years ago

Do we still need this PR? The tsconfig.json is now part of the Skeletons I assume

psimk commented 2 years ago

@ThijsTyZ This PR no, but we probably want to turn @ThaNarie's suggestions into an issue & then PR.