Guidelines for submitting and reviewing pull requests - Githubissues

mediamonks / frontend-coding-standards

Media.Monks - Frontend Coding Standards

60 stars 23 forks source link

Guidelines for submitting and reviewing pull requests #22

Open skulptur opened 3 years ago

skulptur commented 3 years ago

Title and description: what should they contain?
Encourage self review
Scope of the PRs (smaller, focused)
Giving feedback
Receiving feedback (closing the comments with a check, etc)
Reviewing even when not directly added
Closing the branch? Keeping the branch?