mediamonks / frontend-coding-standards

Media.Monks - Frontend Coding Standards
60 stars 23 forks source link

fix `prettier` peer dependency version #49

Closed psimk closed 3 years ago

psimk commented 3 years ago

It seems that npm treats the > 2 version specifier as above the major version 2 ignoring the minor and patch specifiers.

So it only matches on versions, whose major specifier is above 2, e.g. 3. This means, that currently it fails to match the latest version of 2.2.1.

Changing the version specifier to also include major version 2 fixes this (this is what the PR changes). Interestingly, changing > 2 to > 2.0.0 also works, as now it also checks the minor and patch specifiers, but of course excludes the version 2.0.0.