search

mediamonks / frontend-coding-standards

Media.Monks - Frontend Coding Standards
60 stars 23 forks source link

Add a chapter around prefixing resolves #52 #53

Closed jesse-mm closed 2 years ago

jesse-mm commented 3 years ago

Adds information about (not) prefixing types/interfaces.

jesse-mm commented 3 years ago

@ThijsTyZ @ThaNarie @leroykorterink Thanks for contributing great! I've updated the example using the one from @ThijsTyZ . As this one explicitly outlines prefixing. Abbreviation of types was already covered here so I left that out.

Also skipped the emojis like in other suggestions which would break the current documents style.

leroykorterink commented 3 years ago

Does this mean that this chapter is only relevant for prefixing generics? I think adding the examples to https://github.com/mediamonks/frontend-coding-standards#typescript-generics chapter would be more clear than creating a separate chapter.

jesse-mm commented 3 years ago

Does this mean that this chapter is only relevant for prefixing generics? I think adding the examples to https://github.com/mediamonks/frontend-coding-standards#typescript-generics chapter would be more clear than creating a separate chapter.

I agree I think removing it here and moving examples there is even better. With a note we don't prefix types + example.

jesse-mm commented 3 years ago

For the people reviewing this, please have a look at the updated PR.