search

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

Create folder for data files in generator templates #103

Closed pigeonfresh closed 4 years ago

pigeonfresh commented 5 years ago

From experience I like to create multiple data files and store them in a folder called data. This PR will update the generator template used to scaffold a block.

ThaNarie commented 5 years ago

I don't really have an opinion on this, let's ask some others what they think :)

After that, this PR should be updated to move the default muban components/usage to reflect these changes, and of course the documentation :)

ramendezb commented 5 years ago

I always end up creating the data folder manually as well

melsd commented 5 years ago

Same as you and Ronald, I usually create a data folder to store all the data files.

larsvanbraam commented 5 years ago

I'm fine with adding a data folder!

pigeonfresh commented 4 years ago

I've updated the boilerplate data to reflect the use of a folder for data

pigeonfresh commented 4 years ago

@ThaNarie Do we need anything else before this can be merged?

ThaNarie commented 4 years ago

Nope, just the one comment I just posted, after that you can merge it :)