search

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

Override singleQuote option for SCSS files #106

Closed msallent closed 4 years ago

msallent commented 5 years ago

Yesterday I was having some issues with Prettier breaking styles on pre-commit linting.

The project I'm working on needs to support RTL so styles have a lot of [dir=rtl] selectors that Prettier was auto formatting to [dir='rtl'] and breaking them.

Supported format is either [dir=rtl] or [dir="rtl"] so overriding this setting for styling files seems to be a nice solution.

ThaNarie commented 5 years ago

Hi @msallent Seems like something we have to change indeed.

Could you also apply prettier on the codebase with this new settings, and don't forget the seng generator templates :) Thanks!

@ReneDrie @pigeonfresh Do you agree, or see some issues?

msallent commented 5 years ago

Seng Generator styles come only with the class name by default so there's no issue there but I did run Prettier on everything else.

Cheers!

pigeonfresh commented 5 years ago

Matias showed me the issue so if this fixes the issue. If all the files are update I don't see why this could not be merged.