mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

Consider adding seng generator as a local dependency #107

Closed skulptur closed 4 years ago

skulptur commented 4 years ago

Currently we're asking devs to install seng generator globaly. This can be inconvenient when setting up new machines or when we need to code in other machines. We should consider adding seng generator as a dependency and adding a new script to the package.json, for example: "generate": "sg wizard".

flut1 commented 4 years ago

In my opinion we shouldn't add dependencies if we happen to use them often but they are otherwise unrelated to Muban. This way users of Muban are free to pick whatever 'generator-like tooling' they prefer. In my view:

Just my personal opinion. I'm open to alternative suggestions.

skulptur commented 4 years ago

I get your point and I personally use other tools to generate code in my own projects. However since Muban already comes with the templates for seng generator it seems like a disconnect to not include the tool to make those templates work.

flut1 commented 4 years ago

Ah I didn't realize that Muban already comes with templates. In that case I agree with you that does seem like a bit of a disconnect. It might even be a good idea to add a specific version as dependency from a technical standpoint, just in case sg ever gets a major upgrade with a breaking change that's incompatible with the templates in Muban