search

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

Enable tslint rule member-access #111

Closed ThijsTyZ closed 4 years ago

ThijsTyZ commented 4 years ago

We should make it mandatory to always add an explicit member access declaration.

I see a lot of developers leave out the access declaration, which makes something public by default. I think you should only set something to public when it has to be public. Otherwise it should be private (or protected when needed). By enabling this rule we force developers to think about the member accessibility.

See https://palantir.github.io/tslint/rules/member-access/