search

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

Update generator templates #112

Closed ThijsTyZ closed 4 years ago

ThijsTyZ commented 4 years ago

Seng Generator templates update: Add the keyword public and readonly for static displayName and remove disabling of style lint rule by default.

I think we should not disable a linting rule in every template. If we don't like this linting rule, we should disable or remove this rule in the linting settings. We added that rule for a reason, disabling this rule in all css files does not make sense.

ThijsTyZ commented 4 years ago

I think there is a 3rd option: Adding some basic styling so the block is not empty. Then I will suggest something that looks ugly (like bakground: red or something), so people will change it.

The problem with the current situation is that almost nobody removes that line in the scss file that disables the rule.