search

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

update seng-scss to prevent build warning #163

Closed jesse-mm closed 4 years ago

jesse-mm commented 4 years ago

While upgrading to dart-sass the code from seng-scss reported the following:

55 │ $maximumFluidTypeViewportWidth: 1440px !global;
   │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/seng-scss/utils/_variables.scss 55:1  @import
    node_modules/seng-scss/base.scss 1:9               @import
    src/app/component/block/two-col/two-col.scss 1:9   root stylesheet

This is only apparent on build as on dev build this got suppressed.

Upgrading seng-scss to it's latest version solves this issue.