search

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

update source-map properties for development mode. #168

Closed cobiwave closed 3 years ago

cobiwave commented 3 years ago

Hello :)

I left some comments for each commit.

ThaNarie commented 3 years ago

Besides the isDevelopment being incorrectly passed, the other "main" issue is awesome-typescript-loader, I think it only supports 2 types of sourcemap settigs.

  // Source maps support ('inline-source-map' also works)
  devtool: 'source-map',

This mens that the SourceMapDevToolPlugin isn't needed to make this work.

We could also switch to ts-loader, which makes all of the devtool options available again.