mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.

https://mediamonks.github.io/muban/

39 stars 15 forks source link

Excessive data attribute on the basic component #82

Closed larsvanbraam closed 4 years ago

larsvanbraam commented 5 years ago

Since the data-component attribute is only used for initialising the JavaScript I guess it can be removed for components that do not have any functionality?

https://github.com/mediamonks/muban/blob/48ec6ce66fe84a00f4bd0b27ba50271a4e843778/build-tools/generator-template/component/%7Bname_sc%7D/%7Bname_sc%7D.hbs#L3

ThaNarie commented 5 years ago

This is related to #62, the outcome there impacts the choice here.

skulptur commented 4 years ago

62 is closed. We went with using the data-component attribute so the class is what got dropped.