Smart component extends wrong base file.

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.

https://mediamonks.github.io/muban/

39 stars 15 forks source link

Smart component extends wrong base file. #83

Closed larsvanbraam closed 5 years ago

larsvanbraam commented 5 years ago

Currently the smart-component extends the AbstractBlock and this doesn't seem right since it's not a block. I think the smart-component should just extend the AbstractComponent instead.

https://github.com/mediamonks/muban/blob/48ec6ce66fe84a00f4bd0b27ba50271a4e843778/build-tools/generator-template/smart-component/%7Bname_sc%7D/%7Bname_pc%7D.ts#L3

ThaNarie commented 5 years ago

Correct, should be updated to extend AbstractComponent.