search

mediamonks / muban

A backend-agnostic framework to enhance server-rendered HTML using a modern webpack development setup.
https://mediamonks.github.io/muban/
39 stars 15 forks source link

Clean script breaks application #86

Closed larsvanbraam closed 5 years ago

larsvanbraam commented 5 years ago

When you run the yarn clean:boilerplate all the boilerplate code is removed and this includes the src/data/_variables.yaml file.

https://github.com/mediamonks/muban/blob/3cb0f3d071dc896130303e6750d9769be6915ecb/build-tools/script/cleanup.js#L39

The src/app/bootstrap.dev.ts file still requires this file and this causes the application to break!

ThaNarie commented 5 years ago

In that case I'm afraid we need to remove the individual page file instead, as there doesn't seem to be an option in shelljs/node-glob to do a match+ignore in a single pattern.

larsvanbraam commented 5 years ago

Or maybe we can split them up into separate folders? One for pages and one for the variables?

Edit: For now we'll just update the clean script to remove the following files: