search

mediapop / django-friendface

Getting Facebook to work for Django.
2 stars 0 forks source link

Add disables for fburl to act like regular url. #60

Open kitsunde opened 11 years ago

kitsunde commented 11 years ago

It should be possible to disable fburl behavior as otherwise we end up with something like:

{% if condition %}{% fburl foo %}{% else %}{% url foo %}{% endif %}

Instead we could have nofacebook=true as a session variable.

gaqzi commented 11 years ago

we should also add a flag to enable/disable fburl if the user is mobile, since the FB don't like it when you redirect them back to the namespaced url.

On Sun, Feb 24, 2013 at 3:00 PM, Kit Sunde notifications@github.com wrote:

It should be possible to disable fburl behavior as otherwise we end up with something like:

{% if condition %}{% fburl foo %}{% else %}{% url foo %}{% endif %}

Instead we could have nofacebook=true as a session variable.

— Reply to this email directly or view it on GitHubhttps://github.com/mediapop/django-friendface/issues/60.

kitsunde commented 11 years ago

That's pretty much what prompted this ticket. Cause #59 :P

kitsunde commented 11 years ago

@gaqzi

Alternatively we could do the inverse and detect request.FACEBOOK in fburl and only then link to facebook. This would cause fburl to be sticky in cases where we currently want to (i.e. canvas, page tabs), but not on others.

Adding in an optional queryparma like onfacebook=true for certain cases like if we do a post and render error messages inline, we would no longer have a signed_request pressent but obviously want to stay on facebook.

That way we could have one page running on say a website, and another running inside of facebook without needing to remember to juggle session vars. I also think that if the method is opt-in rather than opt-out it'll help when we want to go down the route of embedding, since we'd need to opt-out a lot. Mind you in most cases we have right now we wouldn't even need the opt-in cause we would always link to the canvas root ie. request.facebook.get_absolute_url (or whatever it is).

We would also need to set a flag to fburl since if you are on a page and want to add a link "show on facebook" we would need to override the default in those specific cases.

gaqzi commented 11 years ago

I like this plan!

On Sun, Feb 24, 2013 at 11:59 PM, Kit Sunde notifications@github.comwrote:

@gaqzi https://github.com/gaqzi

Alternatively we could d the inverse and detect signed_request in fburl and only then link to facebook. This would cause fburl to be sticky in cases where we currently want to (i.e. canvas, page tabs), but not on others.

Adding in an optional queryparma like onfacebook=true for certain cases like if we do a post and render error messages inline, we would no longer have a signed_request pressent but obviously want to stay on facebook.

That way we could have one page running on say a website, and another running inside of facebook without needing to remember to juggle session vars. I also think that if the method is opt-in rather than opt-out it'll help when we want to go down the route of embedding, since we'd need to opt-out a lot.

We would also need to set a flag to fburl since if you are on a page and want to add a link "show on facebook" we would need to override the default in those specific cases.

— Reply to this email directly or view it on GitHubhttps://github.com/mediapop/django-friendface/issues/60#issuecomment-14010497.