mediapop / django-friendface

Getting Facebook to work for Django.
2 stars 0 forks source link

Add context_reverse() that works with request to find the path. #71

Closed kitsunde closed 11 years ago

kitsunde commented 11 years ago

right now we have to do:

if request.session.get('is_mobile'):
   url = reverse(..)
else:
   request.facebook_build_canvas_url(reverse(..))

We should be able to do:

url = context_reverse(request, ..)
gaqzi commented 11 years ago

This to make fb_url give back mobile/normal urls? Cause I'm thinking of having a look at that stuff this weekend when I'm doing the Pizza Hut app.

kitsunde commented 11 years ago

@gaqzi No, but that is already fixed: https://github.com/mediapop/django-friendface/commit/19a50c28f773462fccfc77ea7773ff12877db56f

gaqzi commented 11 years ago

@Celc is this still relevant?

kitsunde commented 11 years ago

Should work already.