search

mediapop / django-friendface

Getting Facebook to work for Django.
2 stars 0 forks source link

Trying to create an invitation with invalid friendface user 500s #82

Open gaqzi opened 11 years ago

gaqzi commented 11 years ago

https://sentry.mediapop.co/default/media-pop-clients/group/514483/

gaqzi commented 11 years ago

this affects both the CBV and the FBV

kitsunde commented 11 years ago

Duplicate of #78?

gaqzi commented 11 years ago

Yeah, except we want to fix it in two very different ways. How do you propose the other is to be solved?

Create a fake account or just allow sender to be None?

kitsunde commented 11 years ago

True, this is a separate issue, it shouldn't just explode. Probably need to allow for sender to be None. I think the FacebookInvitiation at some point since there's a few issues:

Maybe we should facilitate some task to be done on invite. So if a user has multiple request_ids, we perform the tasks for all of them.

gaqzi commented 11 years ago

The CBV has a callback function type thing for that. It'll call a callback for every single request the user has accepted, one-by-one.

On Wed, Jul 10, 2013 at 2:00 PM, Kit Sunde notifications@github.com wrote:

True, this is a separate issue, it shouldn't just explode. Probably. I think the FacebookInvitiation at some point since there's a few issues:

  • How to handle multiple requests_ids on accepting an invitation.
  • Users were invited, but it's not recorded on the backend.
  • Users were invited, but it's not recorded on the backend because the ajax callback failed.

Maybe we should facilitate some task to be done on invite. So if a user has multiple request_ids, we perform the tasks for all of them.

— Reply to this email directly or view it on GitHubhttps://github.com/mediapop/django-friendface/issues/82#issuecomment-20723178 .