mediapop / terraform-aws-certificate

Simple way of creating validated certs over multiple domains and zones.
MIT License
3 stars 6 forks source link

Update to terraform 0.12 #1

Closed tampakrap closed 3 years ago

tampakrap commented 4 years ago

I noticed the README and the examples, but I left them for a later commit, as I intend also to submit a few more on top of this. Regarding the EMPTY_LIST hack, if the need of submitting empty domains is still there, then the hack also seems to be still needed. Although I honestly don't understand the purpose of that feature

tampakrap commented 4 years ago

I made the changes also to the README and the examples

kitsunde commented 3 years ago

Thanks. I've released 1.2.0 which supports terraform >= 0.13. The only breaking change should be that the output arn will no longer turn an empty string when there's no domains and instead return null.