mediar-ai / screenpipe

rewind.ai x cursor.com = your AI assistant that has all the context. 24/7 screen & voice recording for the age of super intelligence. get your data ready or be left behind
https://screenpi.pe
MIT License
9.65k stars 568 forks source link

fix: build: ignore ~/.wgetrc to avoid interference #533

Closed devnoname120 closed 1 month ago

devnoname120 commented 1 month ago

name: pull request about: submit changes to the project title: "[pr] fix: build: ignore ~/.wgetrc to avoid interference" labels: '' assignees: 'louis030195'


description

Users can define personal settings for wget in ~/.wgetrc. When the wget command is run it reads this configuration file by default and add the corresponding options. The scripts/pre_build.js script fails when some user options are specified in the configuration file because they conflict with the options that this script uses. The solution is to ignore this user configuration file.

related issue: ø

type of change

how to test

  1. Create a file ~/.wgetrc and just put timestamping = on inside.
  2. Run bun scripts/pre_build.js from screenpipe-app-tauri and confirm that wget errors out because -nc and --timestamp can't be combined.
  3. Move to this branch, and run bun scripts/pre_build.js again. This time around wget works properly.

checklist

additional notes

any other relevant information about the pr.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 0:05am
louis030195 commented 1 month ago

thx @devnoname120