Feat/tray menu/shortcut recording

onyedikachi-david commented 1 month ago

Fixes: #515 /claim #515

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
screenpipe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 13, 2024 2:32pm

louis030195 commented 1 month ago

@onyedikachi-david great work!

can you make sure to follow style guide (e.g. UI strings in lower case like in the cursor rules https://github.com/mediar-ai/screenpipe/blob/main/.cursorrules)
the shortcut UI settings is still a bit weird to me, like i dont get why my shortcut still require cmd when i did not select it?
that would great if you could find how to fix this?

onyedikachi-david commented 1 month ago

https://github.com/user-attachments/assets/2601e66b-15a6-4147-833d-a2d2f31d166c

How do you see this method? @louis030195

louis030195 commented 1 month ago

Screen.Recording.2024-10-22.at.14.55.44.mov How do you see this method? @louis030195

nice, dream would be same UX as obsidian:

https://github.com/user-attachments/assets/f7113e47-e78c-4c25-946e-28899be59cd4

can you make it like this? then make same UX for the other shortcut setting, solve conflict and can merge 🙏

onyedikachi-david commented 1 month ago

is this okay @louis030195

louis030195 commented 4 weeks ago

@onyedikachi-david good!

why is written super? it should be the cmd icon on mac and ctrl on windows i guess

also the shortcut does not work for me

i checked out the PR, did bun tauri dev

pressing the shortcut nothing happen

saving does not work (e.g. changing shortcut, leaving settings page and coming back does not save)

can you fix these and we can merge then

onyedikachi-david commented 4 weeks ago

why is written super? it should be the cmd icon on mac and ctrl on windows i guess

Everything should be working well now. @louis030195

louis030195 commented 4 weeks ago

@onyedikachi-david just changed slightly command.rs for security (app was crashing) can you rebase/resolve conflicts?

onyedikachi-david commented 4 weeks ago

@onyedikachi-david just changed slightly command.rs for security (app was crashing) can you rebase/resolve conflicts?

Just did :)

louis030195 commented 4 weeks ago

@onyedikachi-david saving still does not work, nor the shortcut itself, nothing happen, no notification and not starting the recording

onyedikachi-david commented 4 weeks ago

Wow, that's odd, but can you see these logs?

2024-10-25T16:20:50.929120Z DEBUG screenpipe_app::commands: Registering shortcuts - Show: Meta+Ctrl+Y, Record: Meta+Alt+T
2024-10-25T16:20:50.931642Z DEBUG screenpipe_app::commands: Successfully unregistered existing shortcuts
2024-10-25T16:20:50.931653Z DEBUG screenpipe_app::commands: Parsing show screenpipe shortcut
2024-10-25T16:20:50.931709Z DEBUG screenpipe_app::commands: Starting to parse shortcut: Meta+Ctrl+Y
2024-10-25T16:20:50.934688Z DEBUG screenpipe_app::commands: Split shortcut into parts: ["Meta", "Ctrl", "Y"]
2024-10-25T16:20:50.934735Z DEBUG screenpipe_app::commands: Modifiers: ["Meta", "Ctrl"], Key: ["Y"]
2024-10-25T16:20:50.936304Z DEBUG screenpipe_app::commands: Processing modifier: Meta
2024-10-25T16:20:50.938026Z DEBUG screenpipe_app::commands: Adding META modifier
2024-10-25T16:20:50.938115Z DEBUG screenpipe_app::commands: Processing modifier: Ctrl
2024-10-25T16:20:50.938128Z DEBUG screenpipe_app::commands: Adding CONTROL modifier
2024-10-25T16:20:50.938135Z DEBUG screenpipe_app::commands: Final modifier flags: Modifiers(CONTROL | META)
2024-10-25T16:20:50.945071Z DEBUG screenpipe_app::commands: Attempting to parse key code: KeyY
2024-10-25T16:20:50.945101Z DEBUG screenpipe_app::commands: Successfully parsed key code: KeyY
2024-10-25T16:20:50.946724Z DEBUG screenpipe_app::commands: Parsing recording shortcut
2024-10-25T16:20:50.946732Z DEBUG screenpipe_app::commands: Starting to parse shortcut: Meta+Alt+T
2024-10-25T16:20:50.946777Z DEBUG screenpipe_app::commands: Split shortcut into parts: ["Meta", "Alt", "T"]
2024-10-25T16:20:50.946790Z DEBUG screenpipe_app::commands: Modifiers: ["Meta", "Alt"], Key: ["T"]
2024-10-25T16:20:50.946797Z DEBUG screenpipe_app::commands: Processing modifier: Meta
2024-10-25T16:20:50.946804Z DEBUG screenpipe_app::commands: Adding META modifier
2024-10-25T16:20:50.946817Z DEBUG screenpipe_app::commands: Processing modifier: Alt
2024-10-25T16:20:50.946825Z DEBUG screenpipe_app::commands: Adding ALT modifier
2024-10-25T16:20:50.946831Z DEBUG screenpipe_app::commands: Final modifier flags: Modifiers(ALT | META)
2024-10-25T16:20:50.946840Z DEBUG screenpipe_app::commands: Attempting to parse key code: KeyT
2024-10-25T16:20:50.946846Z DEBUG screenpipe_app::commands: Successfully parsed key code: KeyT
2024-10-25T16:20:50.946880Z DEBUG screenpipe_app::commands: Registering show screenpipe shortcut
2024-10-25T16:20:50.952000Z DEBUG screenpipe_app::commands: Registering recording shortcut
2024-10-25T16:20:50.952119Z DEBUG screenpipe_app::commands: Successfully registered all shortcuts

louis030195 commented 4 weeks ago

yes i do but the ui settings does not update, some issue with the typescript code, also meta key crash my app:

 invalid shortcut 'Meta+Shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:15.474680Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+super+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:18.701527Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:20.764464Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+shift+alt+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:23.644786Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+ctrl+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:25.740428Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:45.954858Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default

isn't it "Super" ? or idk

onyedikachi-david commented 3 weeks ago

https://github.com/user-attachments/assets/c6cbe617-ef18-43a3-b85f-d65d1c95a2ec

louis030195 commented 3 weeks ago

https://github.com/user-attachments/assets/be96580a-291a-435c-b723-60e5d10873e3

still does not save

onyedikachi-david commented 3 weeks ago

There is a bug in the settings UI, it happens to all settings.

Settings changes are being saved to the store but not properly reflected in the UI after page refresh.

louis030195 commented 3 weeks ago

https://github.com/user-attachments/assets/09831b23-f311-4df4-8278-525c0bf83ca3

There is a bug in the settings UI, it happens to all settings.

Settings changes are being saved to the store but not properly reflected in the UI after page refresh.

for me it works

louis030195 commented 3 weeks ago

show screenpipe shortcut stopped working now (save works)

onyedikachi-david commented 3 weeks ago

https://github.com/user-attachments/assets/7887bcdf-4d11-4954-bf77-29d87a44b6a4

show screenpipe shortcut stopped working now (save works)

Just tested it out again and it works well on my side

louis030195 commented 3 weeks ago

@onyedikachi-david i meant the shortcut to show the app (not the one to record which works for me)

onyedikachi-david commented 3 weeks ago

@onyedikachi-david i meant the shortcut to show the app (not the one to record which works for me)

Okay.

I'll see to it. But it should just work, I just moved the function call. 🙂.

onyedikachi-david commented 3 weeks ago

https://github.com/user-attachments/assets/84c4d6d9-f0f7-4ff8-a893-144a88c45bfe

It is fixed now sir. apologies for the stress.

louis030195 commented 3 weeks ago

@onyedikachi-david unfortunately it's still a bit weird:

when i sat cmd+shift+u as shortcut i need to press twice to show up instead of once
when i sat cmd+w as shortcut it wouldn't work at all

https://github.com/user-attachments/assets/783bc904-dc29-40d6-8748-79609bb73e12

onyedikachi-david commented 3 weeks ago

Yes, for the twice stuff, i noticed it myself, i'm using a boolean flag to check if the sidecar is running so i can either start or stop, it is supposed to return Some if running or None if not, but it doesn't, so I have to find a way around it (please see the comment in the code snippet).

 } else if normalized_shortcut == normalized_toggle_shortcut {
                    tokio::task::block_in_place(move || {
                        Handle::current().block_on(async move {
                            let state = app.state::<SidecarState>();
                            let mut sidecar = state.0.lock().await;
                            debug!("sidecar state: {:?}", sidecar.is_some());

                            // Drop the lock before performing actions
                            let is_running = sidecar.is_some(); // This was always returning false even when it is running.
                            *sidecar = None; // Adding this made it work as it does now.
                            drop(sidecar);  

                            if is_running {  
                                debug!("Stopping screenpipe via shortcut");
                                if let Err(err) = kill_all_sreenpipes(state.clone(), app.clone()).await {
                                    error!("Failed to stop recording: {}", err);
                                    let _ = app.notification().builder()
                                        .title("Screenpipe")
                                        .body("Failed to stop recording")
                                        .show();
                                    let _ = app.emit("recording_failed", "Failed to stop recording");
                                } else {
                                    let _ = app.notification().builder()
                                        .title("Screenpipe")
                                        .body("Recording stopped")
                                        .show();
                                    let _ = app.emit("recording_stopped", "Recording stopped");
                                }
                            }

louis030195 commented 2 weeks ago

@onyedikachi-david it would be great to make this work and merge today, i need this for the timeline UI shortcut

onyedikachi-david commented 2 weeks ago

@onyedikachi-david it would be great to make this work and merge today, i need this for the timeline UI shortcut

okay. apologies for the delay.

louis030195 commented 1 week ago

any news on this?

onyedikachi-david commented 1 week ago

I have a fix, will push soon, apologies for the delay.

onyedikachi-david commented 1 week ago

https://github.com/user-attachments/assets/230df0fa-3207-47b0-8779-5d92d60d4010

onyedikachi-david commented 6 days ago

@louis030195 Hi, i don't know if you've gotten time to review this?

louis030195 commented 4 days ago

same issue, i need to press twice the shortcut to work

onyedikachi-david commented 2 days ago

I'm just at lost on how and why this is happening. It happens only for the overlay shortcut. I'll try to figure it out.

mediar-ai / screenpipe

Feat/tray menu/shortcut recording #552