fix: can focus combobox items (#679)

yeonsubak commented 5 days ago

/claim #679

description

Update @radix-ui/react-popover to ^1.1.2 that eventually fix the focusing issue of the combobox items.

related issue: #679 #654

type of change

[x] bug fix
[ ] new feature
[ ] breaking change
[ ] documentation update

how to test

Make sure to have "@radix-ui/react-popover": "^1.1.2" under dependencies in /screenpipe-app-tauri/package.json
Run bun install from /screenpipe-app-tauri in your terminal to update @radix-ui/react-popover
Run bun tauri dev
Once the application has started, go to Settings menu and check the following combobox elements are properly working
- monitors
- audio devices
- languages

if relevant add screenshots or screen captures to prove that this PR works to save us time.

https://github.com/user-attachments/assets/3da3f06f-2993-4029-8b76-1a62527ebed3

checklist

[x] MOST IMPORTANT: this PR will require less than 30 min to review, merge, and release to production and not crash in the hand of thousands of users
[x] i have read the CONTRIBUTING.md file
[x] i have updated the documentation if necessary
[x] my changes generate no new warnings
[x] i have added tests that prove my fix is effective or that my feature works

additional notes

I tried inspecting related components from shadcn library but they all looked good and don't seem to cause the issue. Just out of the intuition, I suspected that it's caused by the Popover component of radix-ui so I updated it to the latest version and it eventually worked.

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
screenpipe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 16, 2024 2:57pm

louis030195 commented 5 days ago

/approve

amazing thanks

algora-pbc[bot] commented 5 days ago

Could not find a claim that corresponds to the PR. Please add the /claim snippet to the PR body first.

louis030195 commented 5 days ago

@yeonsubak can you add the claim for bounty plz

algora-pbc[bot] commented 4 days ago

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

yeonsubak commented 4 days ago

@yeonsubak can you add the claim for bounty plz

Thanks! I added the claim on my PR body.

louis030195 commented 4 days ago

/approve

algora-pbc[bot] commented 4 days ago

@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

louis030195 commented 3 days ago

https://github.com/user-attachments/assets/f5a2faaf-020c-43c1-bc23-2f21229bf65e

i did not test the change and actually it did not work ...

yeonsubak commented 3 days ago

Screen.Recording.2024-11-18.at.11.00.29.AM.mov i did not test the change and actually it did not work ...

Thanks for the feedback! I will check it out. Can you explain how to navigate to that page in the video or list other pages that I can look into?

First, let me try modify Command component as I introduced in shadcn's PR. If it doesn't work, I will thoroughly inspect the elements and their dynamics in the page.

yeonsubak commented 3 days ago

@louis030195 Actually, I ran both bun tauri dev and compiled screenpipe-app.exe without modifying any codes from commit 478fb051 and it seems to be working well.

Could you please check whether the dependency update actually happened in your CI/CD?

how to test

Make sure to have "@radix-ui/react-popover": "^1.1.2" under dependencies in /screenpipe-app-tauri/package.json

Run bun install from /screenpipe-app-tauri in your terminal to update @radix-ui/react-popover

https://github.com/user-attachments/assets/a19e14e2-944f-4dd4-b289-05d91ae90e31

https://github.com/user-attachments/assets/adf28e9c-0b70-48ad-ba9f-72f7cd53bba8

mediar-ai / screenpipe