mediarox / pagespeed

Magento Google Pagespeed Optimization Extension
112 stars 58 forks source link

Conflict with FPC #13

Open Motomotors opened 8 years ago

Motomotors commented 8 years ago

Hi,

Thank you for this module, Its very cool!

I would to know how can I exclude an inline javascript? I can't figure out. Example: <script type="text/javascript"> var <?php echo $Id ?> = new Stuff( '<?php echo $Id ?>Container', '<?php echo $this->getAjaxUrl() ?>', '<?php echo $this->__('Loading...')?>', ); </script>

The problem is the dynamic block cacheing, when fpc is working It caches the moved js in footer but also put back inline javascript to it's original position, and this duplication cause errors. If I prevent to move those inline javascript, that will solve the problem, I guess.

Thank you!

Randydedecker commented 8 years ago

You can add a class name to the inline javascript, this works as well.

I had the same problem. You have to exclude prototype.js as well, otherwise the AJAX call still does not work.

Motomotors commented 8 years ago

Thank you for your answer. I see, but I have no clue what I should to write in the Exclude List at backend. I am not that level to understand regex :D I added a class name like this: <script type="text/javascript" class="donttouch"> truncateOptions(); decorateList('cart-sidebar', 'none-recursive'); $j('document').ready(function() { var minicartOptions = {formKey: "<?php echo $this->getFormKey();?>"} var Mini = new Minicart(minicartOptions); Mini.init(); }); </script>

connectjames commented 7 years ago

Any news on this matter? What regex to include to exclude the inline js?

connectjames commented 7 years ago

Actually you just need to put the class in between / So here : /donttouch/