Closed digitalsadhu closed 9 years ago
@markstuart @matt-in-a-hat Review pls when you get a chance
What was your reasoning for fixed dependencies?
My thinking was that explicit updates means you go through once in a while update all the dependencies, run tests, commit and publish a new version. Means you are forced to be more purposeful with updates. I left dev dependencies dynamic.
What do you think?
On Sun, Jan 18, 2015 at 3:57 PM, Mark Stuart notifications@github.com wrote:
What was your reasoning for fixed dependencies?
Reply to this email directly or view it on GitHub: https://github.com/mediasuitenz/mappy/pull/63#issuecomment-70394492
I actually like this. Probably means we don't need to shrink wrap before releases. We should probably let our contributors know so that they don't worry about the shrink wrap file. Do you want remove the file in this PR?
Can do. Thinking about it, maybe we should fix the dev deps as well?
On Sun, Jan 18, 2015 at 8:32 PM, Mark Stuart notifications@github.com wrote:
I actually like this. Probably means we don't need to shrink wrap before releases. We should probably let our contributors know so that they don't worry about the shrink wrap file.
Do you want remove the file in this PR?
Reply to this email directly or view it on GitHub: https://github.com/mediasuitenz/mappy/pull/63#issuecomment-70399276
Yep, sounds good, keep the contributors test libs in line.
@digitalsadhu, take a look at this when you get a chance please. Lets get this live!
:+1:
Changes to package.json
Changes to testem setup