search

mediatechnologycenter / Aestheval

Code for the paper "Understanding Aesthetics with Language: A Photo Critique Dataset for Aesthetic Assessment"
Creative Commons Attribution 4.0 International
83 stars 5 forks source link

Json files are not generated #16

Closed christina284 closed 1 year ago

christina284 commented 1 year ago

Hello. I am running the steps as proposed on README but I cannot find the json files anywhere in the repo that are needed for step4. Can you help me with this? Is there something I am missing?

dveni commented 1 year ago

Hi there,

Those json files should be the output of step 3. Could you ellaborate a bit more on what is the problem exactly?

dveni commented 1 year ago

Hi Christina,

Just tested the prepare_dataset script and seems to work as expected. I'm closing this issue, but feel free to open it again if I can help you

dveni commented 1 year ago

Hi again and sorry for the previous comment that turns out to be extreamly misleading. Indeed the prepare_dataset works, but every other script does not. I've gonne through all the steps again and patched the code to get the RPCD dataset processed (see last commit 580e336). Please note that this does not solve the (many) issues in the code, which needs a proper re-work, for which I'll try to take some time in the following month.

Please, feel free to submit PRs too if you find new ways of improving the codebase!