mediathekview / MLib

lib für das Projekt MediathekView
GNU General Public License v3.0
35 stars 27 forks source link

Feature/clean up dependencies #109

Closed TheSasch closed 6 years ago

TheSasch commented 6 years ago

Updated Project Dependencies for a better Switch to Maven.

alex1702 commented 6 years ago

SonarQube analysis reported 35 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL FilmlisteLesen.java#L187: Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed. rule
  2. CRITICAL FilenameUtils.java#L175: Refactor this method to reduce its Cognitive Complexity from 57 to the 15 allowed. rule
  3. CRITICAL Functions.java#L45: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  4. CRITICAL Log.java#L250: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. rule
  5. MAJOR FilmlisteLesen.java#L67: Add the missing @deprecated Javadoc tag. rule
  6. MAJOR FilmlisteLesen.java#L78: Remove this unused "PROGRESS_MAX" private field. rule
  7. MAJOR FilmlisteLesen.java#L86: Remove this unused "workMode" private field. rule
  8. MAJOR FilmlisteLesen.java#L154: %n should be used in place of \n to produce the platform-specific line separator. rule
  9. MAJOR FilmlisteLesen.java#L164: Remove this unused method parameter "days". rule
  10. MAJOR FilmlisteLesen.java#L188: Define and throw a dedicated exception instead of using a generic one. rule