search

mediawiki-client-tools / mediawiki-dump-generator

Python 3 tools for downloading and preserving wikis
https://github.com/mediawiki-client-tools/mediawiki-scraper
GNU General Public License v3.0
95 stars 14 forks source link

Revert "Rename log argument and adjust XML format" #59

Closed robkam closed 1 year ago

robkam commented 1 year ago

Reverts elsiehupp/wikiteam3#57 It appeared to be working fine until I requested extraneous parameter #53 @randomnetcat

yzqzss commented 1 year ago

Reverting does not solve the problem. I think the terminal you are using is not using utf-8/unicode, please turn it on. Maybe your terminal cannot print non-windows-1252 or non-ASCII encoded characters.

XML dump should not be affected by this.

robkam commented 1 year ago

The terminal does utf-8/unicode no problem

$ 相关链接
bash: 相关链接: command not found
robkam commented 1 year ago

It does work without a problem on Kubuntu. It also writes a file Special:Version.html Windows chokes on the colon in the filename. I've only now noticed this problem, it's not new.

robkam commented 1 year ago

It works fine on Windows 10, Git Bash and Python 3.11.1 without--stdout-log-file log.txt it gets past the character μ dumpgenerator --failfast --xml --xmlrevisions --api https://sdiywiki.miraheze.org/w/api.php

randomnetcat commented 1 year ago

I don't see why renaming the parameter would affect anything.

robkam commented 1 year ago

I'll open an issue later sometime for failing to write a log file, (only affects Windows).

robkam commented 1 year ago

I thought it had been okay #56 and then not with #57 but I have to go back and take another closer look.