search

mediawiki-client-tools / mediawiki-dump-generator

Python 3 tools for downloading and preserving wikis
https://github.com/mediawiki-client-tools/mediawiki-scraper
GNU General Public License v3.0
89 stars 14 forks source link

`Special:Version.html` to `SpecialVersion.html` #64

Closed robkam closed 1 year ago

robkam commented 1 year ago

Can't have a colon in a Windows file name - save file Special-Version.html instead of Special:Version.html .

randomnetcat commented 1 year ago

A few other places seem to check whether Special:Version.html exists. This also breaks compatibility with the original wikiteam tools (though several of those are also aggressively linux-dependent).

robkam commented 1 year ago

I could only find it elsewhere in launcher.py, fixed that also now.

yzqzss commented 1 year ago

Maybe we should make Special-Version.html as the fallback when Special:Version.html cannot be created, instead of the default.

robkam commented 1 year ago

Windows/NTFS creates an empty file with the name Special you'd have to detect an error. Calling it Special-Version.html won't have any side effects. The file is included mainly to check what extensions are installed.

randomnetcat commented 1 year ago

Please resolve merge conflicts, looks fine after that.