mediawiki-extensions / mw-calendar

Automatically exported from code.google.com/p/mw-calendar
0 stars 2 forks source link

Bad HTML in day view (fix included) #71

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The single day view generates bad HTML as it delivers a table cell without
a table.  If you then use this inside a table bad formatting results. 
Patch against 3.7.2:

--- Calendar.php    2009-04-18 18:30:22.000000000 +0000
+++ /var/lib/mediawiki/extensions/Calendar/Calendar.php 2009-04-30
20:51:06.000000000 +0000
@@ -559,7 +559,7 @@
        $css = $this->stripLeadingSpace($css);

        $ret = $this->buildConfigLink(true). $css
-           . $this->getHTMLForDay($this->month, $this->day, $this->year, 'long',
'day');
+           . "<table>" . $this->getHTMLForDay($this->month, $this->day,
$this->year, 'long', 'day') . "</table>";

        $this->debug->set("renderDate Ended");      
        return $ret;

Original issue reported on code.google.com by je...@convivian.com on 30 Apr 2009 at 9:02

GoogleCodeExporter commented 8 years ago
Hmm... I use "useeventlist=1" instead of single day mode. I'll patch that up in 
the
next release. Thanks!

Eric

Original comment by kenyu73 on 30 Apr 2009 at 9:20

GoogleCodeExporter commented 8 years ago
Ugh, actually.. alot of my html stuff needs cleanup and organization. 

Thanks again for the heads up. 

Original comment by kenyu73 on 30 Apr 2009 at 9:41

GoogleCodeExporter commented 8 years ago

Original comment by kenyu73 on 30 Apr 2009 at 10:43

GoogleCodeExporter commented 8 years ago
Fixed in 3.7.3

Original comment by kenyu73 on 1 May 2009 at 2:40