{period in event causes crash}-Fatal error: Call to a member function...

mediawiki-extensions / mw-calendar

Automatically exported from code.google.com/p/mw-calendar

0 stars 2 forks source link

{period in event causes crash}-Fatal error: Call to a member function... #91

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Wiki Version: 1.15.0
Calendar Version: v3.8.2

Problem:
There is still a problem in v3.8.2. 
Someone entered this ("2 pm Meeting • Lunchroom ") as a calender event in
October.
From then on this month stopped showing with the following error: 

Fatal error: Call to a member function getURL() on a non-object in
/wiki/extensions/Calendar/common.php on line 172

The problem was this letter "•". After deleting it everything is back to
normal!

Original issue reported on code.google.com by martin.k...@googlemail.com on 11 Aug 2009 at 2:04

GoogleCodeExporter commented 8 years ago

Was the "dot" added via copy/paste or using sometype of ASCII code?

I attempted to reproduce it via copy/pasting your event and it appears ok.

Original comment by kenyu73 on 11 Aug 2009 at 3:21

Changed state: Review

Attachments:

[issue 91.JPG](https://storage.googleapis.com/google-code-attachments/mw-calendar/issue-91/comment-1/issue 91.JPG)

GoogleCodeExporter commented 8 years ago

OK, I think I can see where this can occur... If the "dot" is somehow traslated 
into 
a period(.) then the code may attempt to convert it to an Image incorrectly.

I'll have better checks in place for this today.

Original comment by kenyu73 on 11 Aug 2009 at 11:30

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

I've made the change to common.php (rev 213) in the trunk branch. Feel free to 
grab 
it and replace the 3.8.2 version.

This will be in the 3.8.3 release sometime soon... few days.. few weeks... 
depends.

Thanks
Eric

Original comment by kenyu73 on 12 Aug 2009 at 12:06

Changed state: Testing

GoogleCodeExporter commented 8 years ago

Original comment by kenyu73 on 12 Aug 2009 at 12:07

Changed title: {period in event causes crash}-Fatal error: Call to a member function...

GoogleCodeExporter commented 8 years ago

We entered the (dot) via "copy&paste". The original was from a "Word" file.

Great work for the fast fix. I'm looking forward to the new version ;-)

By the way...I have to say: keep up the great work!!! This is one of the best
extensions for MediaWiki.

Original comment by martin.k...@googlemail.com on 12 Aug 2009 at 9:13

GoogleCodeExporter commented 8 years ago

me again: there is another similar problem when entering this: 
 ::16.30-18.00 Meeting : 2

This time the "normal ." (dot) is the problem.

Error: Fatal error: Call to a member function getURL() on a non-object in
/var/www/wiki/extensions/Calendar/common.php on line 172

Original comment by martin.k...@googlemail.com on 12 Aug 2009 at 1:23

GoogleCodeExporter commented 8 years ago

Get the latest common.php from the trunk branch... I made more changes to the 
problem
area. The latest as of this post is 216.

Thanks
Eric

Original comment by kenyu73 on 12 Aug 2009 at 1:28

GoogleCodeExporter commented 8 years ago

I had this issue, updating to the latest revision fixes it though.

Thanks!

Original comment by robert@rhl.me.uk on 12 Aug 2009 at 2:39

GoogleCodeExporter commented 8 years ago

Works like a charm! Thank you!!!

Original comment by martin.k...@googlemail.com on 12 Aug 2009 at 2:40

GoogleCodeExporter commented 8 years ago

v3.8.3

Original comment by kenyu73 on 19 Aug 2009 at 2:15

Changed state: Fixed