Closed halfak closed 9 years ago
General +1, but might need to rebase to trigger Travis?
@yuvipanda remaining flake8 issues are not actually issues. Want me to do anything else?
Was hoping to convince you to do https://github.com/wikimedia/operations-software-tools-webservice/blob/master/toollabs/webservice/__init__.py which is more explicit and takes away the warning as well. The alternative is to comment # noqa at the end of the imports which ignores those imports, but I like the more explicit all version better.
In general it's a good idea to have the minor tests we have passing, I guess.
On Thu, Aug 27, 2015 at 4:21 PM, Aaron Halfaker notifications@github.com wrote:
@yuvipanda https://github.com/yuvipanda remaining flake8 issues are not actually issues. Want me to do anything else.
— Reply to this email directly or view it on GitHub https://github.com/yuvipanda/python-mwapi/pull/11#issuecomment-135450586 .
Yuvi Panda T http://yuvi.in/blog
@yuvipanda {{done}}
Woo!