Add support for boolean and optional parameters

mediawiki-utilities / python-mwapi

Simple Python Wrapper around MediaWiki API

http://pythonhosted.org/mwapi

MIT License

31 stars 11 forks source link

Add support for boolean and optional parameters #38

Closed lucaswerkmeister closed 5 years ago

lucaswerkmeister commented 5 years ago

True parameters are turned into the empty string, and False and None parameters are completely removed from the params dict. Fixes #37.

lucaswerkmeister commented 5 years ago

Side note: I’d gladly add some tests for this behavior if there were any existing tests I could follow, but as I can’t find any tests (doc/Makefile has a doctest target, but it doesn’t seem to run any tests), I don’t even know what framework I should be using :(

Ladsgroup commented 5 years ago

flake8 failure is unrelated.

lucaswerkmeister commented 5 years ago

Are there release notes or something that should be updated? Strictly speaking, this is a breaking change, I suppose.