search

mediawiki-utilities / python-mwapi

Simple Python Wrapper around MediaWiki API
http://pythonhosted.org/mwapi
MIT License
31 stars 11 forks source link

Change 'asyncio.exceptions.TimeoutError' to 'asyncio.TimeoutError' #47

Closed AikoChou closed 2 years ago

AikoChou commented 2 years ago

In Python 3.7, 'asyncio.exceptions.TimeoutError' raises AttributeError: module 'asyncio' has no attribute 'exceptions', since it's in class 'concurrent.futures._base.TimeoutError'. In Python 3.8 onward, TimeoutError is in class 'asyncio.exceptions.TimeoutError'. Written as 'asyncio.TimeoutError' will be acceptable for either version.

Bug: T313493

elukey commented 2 years ago

LGTM! @halfak sorry to bother you again, but if you have time we'd need another round of review + release (0.6.1). Thanks in advance!

AikoChou commented 2 years ago

Thanks for your help to merge code and release :)