search

mediawiki4intranet / IntraACL

IntraACL extension
http://wiki.4intra.net/IntraACL
Other
20 stars 18 forks source link

Some ACLs are ignored when adding lots of ACLs #50

Open mgiacomoli opened 8 years ago

mgiacomoli commented 8 years ago

Hello

Mediawiki: 1.23.13 IntraACL: 2.1.9.1 (9116dcb)

I added lots of ACLs to pages belonging to a custom Namespace (NS1). Then I set $haclgOpenWikiAccess = false; and added an ACL to Special:Search

{{#access: assigned to = # | actions = *}}
{{#manage rights: assigned to = User:Test}}

Result: When trying to open page Special:Search, with few ACLs (NS1 related) it works, but with lots of ACLs it redirects me to Permission Denied page. Here are the hacllogs: hacllog-few-ok.txt hacllog-lot-ko.txt

Best regards

vitalif commented 8 years ago

Hi! Yes, it seems like a continuation of #49. Try to remove && $seenGeneral from if() condition on line 525 of Definition.php and check if it helps?

mgiacomoli commented 8 years ago

Hi! Thank you for your response, if condition now is if (count($rules) >= $iaclPreloadLimit && $userID), but still no luck. The hacllogs are the same.

vitalif commented 8 years ago

Hm... strange. And what if you set $iaclPreloadLimit to 20000 in LocalSettings.php? Does it fix the issue? (it should because it will basically make IntraACL preload everything...)

mgiacomoli commented 8 years ago

Yes, setting $iaclPreloadLimit to 20000 fixes the issue

mgiacomoli commented 8 years ago

Hi @vitalif ! Any new regarding this bug?

Best regards

vitalif commented 8 years ago

I don't know what's the cause of this issue... Only a debug session may help us :) I'd do the following: