Open mojo2012 opened 3 years ago
same need!
Having same issue. Leaving error details for those searching
I’ll make a PR against this to see if I can help out
npm ERR! While resolving: @medibloc/nestjs-request-context@1.0.0
[32] npm ERR! Found: @nestjs/common@8.4.4
[33] npm ERR! node_modules/@nestjs/common
[34] npm ERR! @nestjs/common@"~8.4.4" from the root project
npm ERR! Could not resolve dependency:
[44] npm ERR! peer @nestjs/common@"^7.5.5" from @medibloc/nestjs-request-context@1.0.0
I have created #7 to resolve this issue. Looking forward to review
ALTERNATIVE SOLUTION:
This issue can also be solved by installing another clone of this project that someone else made on npm
npm install nestjs-request-context
@medibloc/nestjs-request-context
with nestjs-request-context
RequestContext.get()
into other notations such as RequestContext.currentContext.req
However eventually overtime that package will have the same issue because it has peerDependencies that require nestjs 8 so if 9 comes out we will hit this same issue again. Here is a link to the peerDependencies that are bad
@mojo2012 my changes have been merged. I have requested these changes to be published to npm. You should be able to test the change in v1.0.1
Be well. Close issue when satisfied.
works well with
"@nestjs/common": "^8.0.0",
"@nestjs/config": "^2.0.0",
"@nestjs/core": "^8.0.0",
"@nestjs/platform-express": "^8.0.0",
Hi,
this project is awesome. Unfortunately it still depends on
@nestjs/common@"^7.5.5
. Could you please keep it updated with the newest nestjs releases.Best regards, matthias