search

medibloc / panacea-core

MediBloc Blockchain Core
https://medibloc.com
Other
60 stars 19 forks source link

feat: proto for oracle upgrade and its skeleton #577

Closed 0xHansLee closed 1 year ago

0xHansLee commented 1 year ago

close #575

proto messages and skeleton code for the txs and queries.

Apart from OracleRegistration, I defined OracleUpgrade which is a set for MsgUpgradeOracle for now. When developing functions, if it seems that it is better to combine them, then let's merge them.

BTW, the name of OracleUpgrade is little bit confusing, so if you have any good idea for this, please feel free to leave your thoughts.

0xHansLee commented 1 year ago

I merged #578 into this branch and changed base branch to ft/570/upgrade-endblocker. Because both query for oracle upgrade info and proto messages are needed to develop oracle.

gyuguen commented 1 year ago

I think seperating OracleRegistration and OracleUpgrade is a good choice. Because required paramter are different for OracleRegistration and OracleUpgrade. OracleUpgrade is not required oracleCommissionRate, oracleCommissionmaxRate and oracleCommissionMaxChangeRate.

gyuguen commented 1 year ago

I too think the OracleUpgrade name is confusing. But I can't think of a good name. :)

Let's think about this.