medibloc / panacea-core

MediBloc Blockchain Core
https://medibloc.com
Other
60 stars 19 forks source link

feat: did module spec change through application of did document proof #633

Closed audtlr24 closed 1 year ago

audtlr24 commented 1 year ago

Background

In aries-framework-go, DocumentSigner.Sign and VerifyProof methods are provided to verify the signature of the did document.

Also, in the Proof of the document, there are Domain and Nonce that can replace the existing sequence to prevent replay-attack.

Implementation

Remove the signature from the existing tx and replace it with the proof inside the document

Remove the sequence part and change to use the Domain inside the document proof

Add a Deactivated field at DIDDocument and simply replace the related tx.

audtlr24 commented 1 year ago

I'm closing this PR in its current state. Since that aries is following a previous w3c spec and aries is not based on protobuf, it seems like a good idea to stick with the existing v2 x/did and not apply it right away.

I'll reopen it later if we need the various features of aries in a VC/VP-based datadeal model.