search

medic / angular10-migration

0 stars 0 forks source link

Review whether scroll action is needed in settingSelected global action #127

Open njogz opened 3 years ago

njogz commented 3 years ago

The settingSelected currently does not have a scroll to top action as it previously did in master.

The fact that we show the spinner for at least a fraction of a second when we load a different "item" (checked on reports) effectively makes it so the wrapping div doesn't even have a scroll. Confirm the same is true for contacts and messages and if so change all calls to this action to remove the refreshing argument.

latin-panda commented 3 years ago

I think actions & effects shouldn't do view work like scrolling. If needed, better in the component that's owner of the view.