search

medic / angular10-migration

0 stars 0 forks source link

CI process fails because no Docker Hub credentials when PR comes from external contributors #131

Closed mrsarm closed 3 years ago

mrsarm commented 3 years ago

We are using GH Actions instead of Travis in the Angular 10 codebase, and when a PR is made by an external contributor the CI process fails because the lack of Docker Hub credentials, so we should skip the login for these contributions like the Travis CI pipeline.

Screenshot from 2021-01-26 09-46-36

This is the fix we made in Travis to skip the login when credentials are not available: https://github.com/medic/cht-core/commit/8af238504c163a73d533881b8d6f0d60c39bd974

We use a plugin to do the login so we cannot skip the signup the same way but I'm working in a solution using the if operator from GH Actions that allows to skip steps.

This PR is blocked because of this error and we can use it to test the solution: https://github.com/medic/cht-core/pull/6841

mrsarm commented 3 years ago

Waiting https://github.com/medic/cht-core/pull/6841#discussion_r567831730 to be merged with the changes from here to test the solution and move the ticket to AT.