search

medic / angular10-migration

0 stars 0 forks source link

Add a logging service for Webapp #24

Open dianabarsan opened 3 years ago

dianabarsan commented 3 years ago

We used to use AngularJS $log before. I couldn't find a consensus about how to log stuff in Android apps (ngx-logger, our custom logging service, other?) when I was migrating the 1st parts of the app, so I just default to console..

We already have a console interceptor (https://github.com/medic/cht-core/blob/4750-angular-10-take-2/webapp/src/ts/services/feedback.service.ts) so we're already somewhat in control.

Evaluate which option to use (addressing needs and not just bloating with functionalities we don't care about).

latin-panda commented 3 years ago

Removing ticket from this iteration, the current solution is sufficient but we can reconsider other options in later iteration.

latin-panda commented 3 years ago

When working on this ticket -> Remember to update the eslint rules in/webapp/.eslintrc, the rule: no-console.