search

medic / bikram-sambat

Javascript and Java utilities for converting between the Nepali Bikram Sambat (Vikram Samvat) and Gregorian (standard European) calendars.
Apache License 2.0
10 stars 10 forks source link

Support more dates (eg. <1950) #8

Closed grzesiek2010 closed 5 years ago

grzesiek2010 commented 5 years ago

I work as an Android developer on ODK Collect where we use this project. Recently one of our users wanted to use not supported dates <1950 https://forum.opendatakit.org/t/bikram-sambat-nepali-date-widget/16844

Is it possible to support more dates?

grzesiek2010 commented 5 years ago

@alxndrsn would you be able to do that?

alxndrsn commented 5 years ago

Hi @grzesiek2010, I'll try to get data for extending the supported date range.

grzesiek2010 commented 5 years ago

I'll try to get data for extending the supported date range.

Thanks!

alxndrsn commented 5 years ago

Fix https://github.com/medic/bikram-sambat/issues/9 and once confirmed that our current data agrees with https://github.com/bahadurbaniya/Date-Converter-Bikram-Sambat-to-English-Date, extend using the month-length values from that implementation: no other source of month length data has been found.

naveagar commented 5 years ago

Is that solved?

garethbowen commented 5 years ago

@naveagar Not yet. I'm going to try and get to it this week.

naveagar commented 5 years ago

@garethbowen will be very helpful as Nepal is going to implement this widget by 1 Feb, if worked, otherwise, have to use English Cal. Thank you so much in advance.

garethbowen commented 5 years ago

@naveagar @grzesiek2010 I think this is now fixed. I've released v1.1.0 of the jar to the maven repo, and v1.6.0 of the js library and v1.5.0 of the bootstrap plugin to npm. Let me know if you have any issues!

naveagar commented 5 years ago

@garethbowen Thanks a lot. Someone has to now update ODK, so that I can update my app.

grzesiek2010 commented 5 years ago

@garethbowen Thanks a lot! I've just created a pr https://github.com/opendatakit/collect/pull/2814

@naveagar we are going to release v1.19.0 next week so hopefully that pr will be included.

alxndrsn commented 5 years ago

@garethbowen has this been released to Maven Central, or still in https://staging.dev.medicmobile.org/_couch/maven-repo?

garethbowen commented 5 years ago

It's still in staging.dev. It'd be good to move it to maven central some time.

naveagar commented 5 years ago

Any idea, when the v1.19.0 (with Bikram Sambat) will get released?

grzesiek2010 commented 5 years ago

@naveagar our plan is to release that version on Sunday (February 3rd). Does that work for you? Here is a not official apk with that fix: collect-debug-v1.19.0-beta.0-10-gd2683ba.apk.zip It would be good if you can test it and give feedback.

naveagar commented 5 years ago

@grzesiek2010 Thanks for providing beta version,I have tested Nepali calendar and it is working fine now. Is this apk has any other update apart from Nepali calendar? I can use this apk also but I wonder if this has been tested for any other changes or not.

if it could be little then 3-Feb then would be better, as the team will be deployed from 4th Feb and need some time to setup the devices.

grzesiek2010 commented 5 years ago

@naveagar I would rather recommend using the app from the Play Store. @yanokwa what do you think? Maybe we can release on Saturday?

yanokwa commented 5 years ago

Assuming no major issues are found in the next few days. I'm glad to release end of day on Friday (San Diego time).