search

medic / cht-android

A native Android container for Community Health Toolkit (CHT) applications
GNU Affero General Public License v3.0
25 stars 50 forks source link

chore (#317) - eCHIS Kenya domain change for 33 of 47 counties #318

Closed kennsippell closed 1 year ago

kennsippell commented 1 year ago

317

kennsippell commented 1 year ago

@jkuester Any tips on getting tests to pass on this PR? I'm seeing failures in the unbranded APK but I'm not making changes there. I'll investigate but let me know if anything jumps to mind since I don't have experience with these tests.

jkuester commented 1 year ago

@kennsippell sorry for the late response here! I forgot to circle back to this last week. It looks like the tests did eventually pass out here, but for what it is worth, I ran into the same issues with the tests in my PR: https://github.com/medic/cht-android/pull/320

TLDR is I was able to fix them by adding a few sleeps so the UI has time to catch up before the test moves on. (Definitly not a perfect solution, but it is consistent with the current pattern in the tests. A more complete and sophisticated refactor needs to happen in the future.)

I think you should be good to merge this PR now as it is and then when #320 lands it should sort out the testing problem.