I agree with @jkuester - the failure probably has nothing to do with this PR. Let me know when it's ready and I can force merge this to get past the blocking required build.
@jkuester Would you mind raising an issue about the test failure? So far what I have is...
Slightly sus looking [DDMLIB]: An unexpected packet was received before the handshake. errors. But these are probably not causing this failure.
It's trying to log in to gamma-cht.dev (I think) which is in a bad state. Firstly the admin password in 1pass doesn't work so I can't log in. Secondly the /api/v1/monitoring URL 404s which implies it's a really old instance. It should be wiped and reset to 4.4 or deleted from the android app picker. A quick test would be to change the test to try logging in to "gamma.dev" instead (list item 2).
As Josh pointed out it's loading the spinner page. To clarify, it's the spinner page from the webapp not the login page. What should happen is that page loads, the JS downloads, and then the JS executes, which detects there's no session, and redirects to the login page. Any one of these steps could be failing. It's possible the instance is just bricked, or that we need to enable javascript, or we need to allow redirects, or we just need to give it more time.
I do not see how it could be a Gamma problem since it works fine locally. (And even after a 2min wait on the CI, it never made it to the login page...)
I agree with @jkuester - the failure probably has nothing to do with this PR. Let me know when it's ready and I can force merge this to get past the blocking required build.
@jkuester Would you mind raising an issue about the test failure? So far what I have is...
[DDMLIB]: An unexpected packet was received before the handshake.
errors. But these are probably not causing this failure.