search

medic / cht-android

A native Android container for Community Health Toolkit (CHT) applications
GNU Affero General Public License v3.0
25 stars 51 forks source link

fix(#308): Add autoverify=true to AndroidManifest.xml file #353

Closed sugat009 closed 7 months ago

sugat009 commented 7 months ago

This PR contains the changes for auto-verification of the domain with the app for deeplinks. This would only partially fix 308 .

jkuester commented 7 months ago

@lorerod I removed you from this PR since there is not any change in functionality happening as a result of this (trying to keep unnecessary things off your plate!). This functionality is currently non-operable and un-usable for the user because https://github.com/medic/cht-core/issues/8917 has not been addressed on the cht-core side. The only reason for including this functionality here now in cht-android is because of the high program costs associated with deploying new apk versions. We want to get this baked in now so it can start getting deployed, instead of waiting until we actually need it (which would be too late). When we go to address the cht-core functionality, we will circle back for considerable workflow testing of this functionality.

sugat009 commented 7 months ago

🚀 LGTM! Just a reminder that we should document (in as much detail as possible) how we tested this functionality and what we learned about the behavior. This can go either here in the PR or just in the issue thread.

I was planning on writing the steps to test the changes from this PR in the issue itself because another PR for the manual verification and the e2e tests are incoming as well so I wanted to have the test process in one place for future references.