medic / cht-app-monitoring-data-ingest

GNU General Public License v3.0
1 stars 0 forks source link

System should have single criteria for projects to be monitoring #98

Closed kennsippell closed 1 year ago

kennsippell commented 1 year ago

To be monitored by this system should have status = 'Active' in impactconfig. But while investigating https://github.com/medic/app-services-team/issues/445, I found that ingest functions update data for partners which have close_date IS NULL

There are four projects including vhtapp which are in a conflicting state: they have both state = 'Active' but not close_date IS NULL. Similarly, there are two projects which are set to Closed but do not have a close_date.

We should have one criteria to be monitored or not.