Closed mukesh2006 closed 5 years ago
@mukesh2006 This happens when uploading standard
config from medic-webapp master
onto a 2.18
instance?
Can this be closed, or would it be helpful if medic-conf
detected this issue and prevented upload of incompatible config?
What is it that makes that config incompatible in this case?
I don't think we should close the issue until we know what is causing the 502, and can then decide the best way forward.
@abbyad it's the reworked permissions
that make the config incompatible.
Ah, thanks. In that case it would be nice for medic-conf to detect the incompatible config before uploading.
@dianabarsan the issue you quoted is 3.4, whereas the original issue is about upgrading to 2.18. Is there another issue related to this one?
@abbyad the issue was about installing the standard
config from master
(3.4 which includes the change) onto a 2.18 instance.
This is the related issue from medic-projects: https://github.com/medic/medic-projects/issues/5469#issuecomment-443117154
Ah, thanks for clarifying.
Projects are still pointing to master, although we coincidentally discussed this last week with some teammates to make sure Standard projects point to a released version of the Standard config in their package.json:
"dependencies": {
"medic": "git@github.com:medic/medic-webapp.git#3.2.x"
},
Follow up documentation is coming from that discussion.
I think it will be helpful if medic-conf
detected this issue and prevented uploading incompatible config. @abbyad @alxndrsn
NB: we have, buried in git history a (incomplete and partially incorrect) settings schema in kanso.json:settings_schema
.
My 2c is that we should dredge that up, correct it, and ship it in api. Then medic-conf doesn't need to know what version you're pushing to, and api can validate your config against the correct schema.
Here's the issue to "dredge that up": medic/medic-webapp#4783
Instance: http://bss-in.app.medicmobile.org/
Steps to produce:
medic-conf compile-app-settings
: No errormedic-conf --instance bss-in.app
: It gives the following error:After this
error
, the instance starts 502ing, and I'm unable just to upload theapp_settings.json
using the commandmedic-conf --instance bss-in.app upload-app-settings
fails with following error:@alxndrsn @SCdF @abbyad