medic / cht-conf

A command-line interface for configuring Community Health Toolkit applications
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
22 stars 25 forks source link

compile-app-settings with --debug flag does not ignore eslint errors #533

Closed kennsippell closed 1 year ago

kennsippell commented 1 year ago

Describe the bug The compile-app-settings -- --debug flag

To Reproduce

  1. Remove a semicolon from tasks.js
  2. Run compile-app-settings -- --debug

Expected behavior Eslint error should be skipped https://github.com/medic/cht-conf/blob/main/release-notes.md#debug-mode-for-compile-app-settings

Environment

Additional context Regression from https://github.com/medic/cht-conf/issues/414

kennsippell commented 1 year ago

@garethbowen @dianabarsan Now that this has passed code review what happens next?

garethbowen commented 1 year ago

@kennsippell The process is to send it for AT. Add it to the Product Team Activities project, and move it to the Ready for AT column. Add a comment to this issue with AT instructions (in this case, this isn't necessary because you've added reproduction steps above!).

When it passes AT, remember to be careful when merging to use the specific commit format so it gets released in the CD process.

kennsippell commented 1 year ago

Ready for AT on debug-eslint-warning

ngaruko commented 1 year ago
  1. Reproduced on main branch
  2. Tested on debug-eslint-warning.
  3. Checked if branch still fail when no --debug flag is added
  4. See recording Ready to merge @kennsippell
medic-ci commented 1 year ago

:tada: This issue has been resolved in version 3.16.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: