medic / cht-conf

A command-line interface for configuring Community Health Toolkit applications
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
23 stars 25 forks source link

feat(#575): retry failed commands #590

Closed m5r closed 9 months ago

m5r commented 9 months ago

Description

This one catches failures a level higher compared to #583, it retries a command as a whole instead of the more granular HTTP request that #583 does

medic/cht-conf#575

Code review items

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

m5r commented 9 months ago

@kennsippell could you share your take as to what would be the better and more robust approach between this PR and #583 to make sure cht-conf stays reliable for deployments like Muso Mali

jkuester commented 9 months ago

I concur with Gareth's comment that #583 is probably a more viable fix than this PR. One additional point to consider is that this approach would not be super helpful when an action might involve a large amount of HTTP requests. For example, if you have 100+ forms, the upload-app-forms action is going to make a ton of HTTP requests. Retrying at the action level is not going to be very helpful in getting the action to complete successfully....