medic / cht-conf

A command-line interface for configuring Community Health Toolkit applications
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
23 stars 25 forks source link

fix(#26): add warning if jsonDir contains file when running csv-to-doc command #603

Closed sugat009 closed 7 months ago

sugat009 commented 7 months ago

Description

Added warning if jsonDir contains files when running csv-to-doc command.

medic/cht-conf#26

Screenshots

  1. When jsonDir does not exists image
  2. When jsonDir exists and user wants to continue after prompt is shown image
  3. When jsonDir exists and user does not want to continue after prompt is shown image

Code review items

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

jkuester commented 7 months ago

Also, I added @tatilepizs to this PR so we can get QA's perspective here too!

andrablaj commented 7 months ago

@jkuester, my bad for not having @tatilepizs added to this PR, and thanks for doing that. @sugat009 asked me about it this morning, and as it was a small change and the PR was already ready for review I figured that it didn't need extra QA support. Thanks for keeping me honest!

tatilepizs commented 7 months ago

That is fine @andrablaj, and thank you @jkuester 🙂 What I like about those PRs is that I am constantly learning about the development and the feedback

medic-ci commented 7 months ago

:tada: This PR is included in version 3.21.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: