medic / cht-conf

A command-line interface for configuring Community Health Toolkit applications
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
23 stars 25 forks source link

chore(#621): update non-breaking dependencies #623

Closed m5r closed 1 month ago

m5r commented 1 month ago

Description

Update all dependencies at once is an important effort so I'm splitting this up in more manageable chunks, starting with non-breaking (or minimally breaking) dependencies

medic/cht-conf#621

Decisions made along the way:

Code review items

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

m5r commented 1 month ago

@jkuester the PR is pretty much ready for review. The last test I fixed shows diff when local is different from remote and the user requests a diff has a weird behavior where the terminal "color code prefixes" are part of the diff locally but not in the CI ever since I updated json-diff. I'll fix this first thing tomorrow but I don't expect it to be an important change

jkuester commented 1 month ago

FYI, just opened a docs PR (https://github.com/medic/cht-docs/pull/1460) for disabling the Sonar TODO rule. Seems to do more harm than good...

jkuester commented 1 month ago

@m5r it looks like this TODO rule fall into the annoying category of Sonar rules that do not seem to be ignorable via the normal inline means. :thinking:

I guess we can either just remove the comments (since they are getting fixed anyway in https://github.com/medic/cht-conf/pull/624) or you should be able to bypass them in the Sonar UI by "Accepting" them (hopefully if you are logged into Sonar you can see the drop-down to change the status from Open to Accepted?):

Screenshot from 2024-07-18 11-47-52

m5r commented 1 month ago

@jkuester Sure, I'll remove them in this branch :+1:

m5r commented 1 month ago

Holding off to merge this branch. I noticed a regression in unit tests that I pinpointed to the unsubscribe of @parcel/watcher hanging in src/fn/watch-project.js. I re-ran it locally with the version we were previously running with and it never hangs. I need to look into which version introduced this change, see if there is something we can do on our side to prevent it from hanging or possibly keep using an old version of this package. What's surprising is this wasn't a major version update, we were behind by a few minor versions only...

Here is an example run where it hanged for ~20 minutes until I canceled it. The weird thing is that canceling it didn't work immediately and it took a few minutes for GitHub to actually stop the run. Same thing happens in local where CTRL+C won't stop the process, the ^C signal doesn't even show up in the terminal, you have to kill -9 the node process to get it to stop.

medic-ci commented 2 weeks ago

:tada: This PR is included in version 4.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: