search

medic / cht-core

The CHT Core Framework makes it faster to build responsive, offline-first digital health apps that equip health workers to provide better care in their communities. It is a central resource of the Community Health Toolkit.
https://communityhealthtoolkit.org
GNU Affero General Public License v3.0
438 stars 209 forks source link

Integration test for non-ascii search #3516

Open estellecomment opened 7 years ago

estellecomment commented 7 years ago

Write an e2e test to check that we deal with non-ascii text (especially french accents and nepali/hindi devanagari alphabet) properly all the way through. Include search, since that had issues (#3392).

Edit : both couch and pouch!

estellecomment commented 7 years ago

One behavior to test : when you query for key ['aaa'], you should get ['ààà'] in results (maybe just a db test? Since it doesn't need the client really... But it does need the full DB, it's not covered by view unit test.)

nice-snek commented 7 years ago

hi frand @SCdF, please triage before the end of this sprint.

SCdF commented 7 years ago

@estellecomment is this e2e specifically because you want to make sure select2 etc is in on the game? Does it work right now, and this is future proofing? Or are we unsure if it works? Do we think that we are going to refactor this code to make it go from working to not working?

SCdF commented 6 years ago

Still useful. I don't think it has to be an E2E test though, just an integration test with both PouchDB search and CouchDB search.